Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOSS: Fix setting of exodiff binary in tests #7421

Merged
merged 1 commit into from
May 24, 2020
Merged

IOSS: Fix setting of exodiff binary in tests #7421

merged 1 commit into from
May 24, 2020

Conversation

gsjaardema
Copy link
Contributor

A previous commit tried to improve the setting of the path to the
exodiff binary, but mistakenly added a method that only worked on
a preexisting build. On a clean build, it would result
in an empty symbol which resulted in an empty program name following
the CMND keyword.

This fixes that problem.

Fixes #7420. We really need to add cgns to at least one of the Trilinos checkin builds.

@trilinos/seacas

Motivation

Stakeholder Feedback

Testing

@gsjaardema
IOSS: Fix setting of exodiff binary in tests
321f252 
A previous commit tried to improve the setting of the path to the
exodiff binary, but mistakenly added a method that only worked on
a preexisting build.  On a clean build, it would result
in an empty symbol which resulted in an empty program name following
the CMND keyword.

This fixes that problem.
@gsjaardema gsjaardema added pkg: seacas ATDM Config Issues that are specific to the ATDM configuration settings AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Data Services Issues that fall under the Trilinos Data Services Product Area labels May 23, 2020
@gsjaardema gsjaardema self-assigned this May 23, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6796
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6608
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5033
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4880
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1070
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4369
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 744
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2506
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2517
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Using Repos:

Repo: TRILINOS (gsjaardema/Trilinos)
  • Branch: seacas-fix-exodiff-tests
  • SHA: 321f252
  • Mode: TEST_REPO

Pull Request Author: gsjaardema

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6796
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6608
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5033
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4880
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1070
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4369
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 744
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2506
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2517
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7421
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH seacas-fix-exodiff-tests
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 321f252
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cb3e80a


CDash Test Results for PR# 7421.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

bartlettroscoe
bartlettroscoe approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsjaardema, thanks for the fast fix!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 160ac5e into trilinos:develop May 24, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 7421: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label May 24, 2020
@gsjaardema gsjaardema deleted the seacas-fix-exodiff-tests branch May 24, 2020 14:13
@bartlettroscoe bartlettroscoe mentioned this pull request Aug 4, 2020
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

@prwolfe prwolfe Awaiting requested review from prwolfe

Assignees

@gsjaardema gsjaardema

Labels
ATDM Config Issues that are specific to the ATDM configuration settings PA: Data Services Issues that fall under the Trilinos Data Services Product Area pkg: seacas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsjaardema @trilinos-autotester @bartlettroscoe